Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651) #199971

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

machadoum
Copy link
Member

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

… are duplicated (elastic#199651)

## Summary

* Improve asset criticality bulk error when entities are duplicated
* It also fixes the server errors line to be '1' based.

![Screenshot 2024-11-11 at 11 46
31](https://github.com/user-attachments/assets/3fbf35fb-cd27-417a-bf53-41a197d1bbe9)

### Performance

Test parameters: file with +33k lines and ~1 MB size.
* Before 6.24 seconds
* After 6.46 seconds

Execution time Increased  ~0.22 seconds

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 02ac5fc)
@machadoum machadoum merged commit ed68974 into elastic:8.16 Nov 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants